Skip to content

Commit

Permalink
[BACKPORT 2.18.5][PLAT-11919] New Tservers created after adding new A…
Browse files Browse the repository at this point in the history
…Zs do not have YBC running

Summary:
Original commit: 82b40fc
Original PR: https://phorge.dev.yugabyte.com/D31075
- Issue due to master partitioned rolling updates passing `ybc:\n enabled: false` which changes tserver spec and the changes take effect due to tserver partition set to 0.
- Fixed by adding ybc helm value to true even for master rolling updates.

Test Plan:
Tested AZ migration flow and verified that the new Tservers have YBC installed.

```
Initial Placement:
- Contains only 1 AZ - us-west-1a
- 3 nodes in the same AZ

Final Placement:
- Added 2 AZs
- Contains 3 AZs now - us-west-1a, us-west-1b, us-west-1c
- 1 node in each of the 3 AZs
```

Also tested shrinking from 3 AZ to 2 AZ placement

Reviewers: sneelakantan, anijhawan

Reviewed By: sneelakantan

Subscribers: yugaware, anijhawan

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D31148
  • Loading branch information
kv83821-yb committed Dec 18, 2023
1 parent 0afd9b7 commit 9c842fb
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,10 @@ private boolean editCluster(
true,
true,
newNamingStyle,
isReadOnlyCluster);
isReadOnlyCluster,
KubernetesCommandExecutor.CommandType.HELM_UPGRADE,
universe.isYbcEnabled(),
universe.getUniverseDetails().getYbcSoftwareVersion());
}
if (instanceTypeChanged || restartAllPods) {
upgradePodsTask(
Expand Down

0 comments on commit 9c842fb

Please sign in to comment.