Skip to content

Commit

Permalink
Merge pull request #322 from icefoganalytics/test
Browse files Browse the repository at this point in the history
NARS fixes and documentation link
  • Loading branch information
datajohnson authored Dec 2, 2024
2 parents 90aed01 + 54f40f7 commit a4d4d87
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
3 changes: 2 additions & 1 deletion src/api/services/admin/nars-pt-reporting-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ export class NarsPTReportingService {
LEFT JOIN (SELECT SUM(COALESCE(paid_amount, 0)) disbursed, max(issue_date) issue_date, funding_request_id, assessment_id
FROM sfa.disbursement WHERE financial_batch_serial_no IS NOT NULL GROUP BY assessment_id, funding_request_id) d ON (funding_request.id = d.funding_request_id and assessment.id = d.assessment_id)
where
funding_request.request_type_id = 5`);
funding_request.request_type_id = 5
and application.academic_year_id = ${this.year}`);

for (let student of this.allApplications) {
let rows = await this.makeRows(student);
Expand Down
3 changes: 2 additions & 1 deletion src/api/services/admin/nars-v17-2-reporting-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ export class NarsV17_2ReportingService {
LEFT JOIN (SELECT SUM(COALESCE(paid_amount, 0)) disbursed, max(issue_date) issue_date, funding_request_id, assessment_id
FROM sfa.disbursement WHERE financial_batch_serial_no IS NOT NULL GROUP BY assessment_id, funding_request_id) d ON (funding_request.id = d.funding_request_id and assessment.id = d.assessment_id)
where
funding_request.request_type_id = 4`);
funding_request.request_type_id = 4
and application.academic_year_id = ${this.year}`);

for (let student of this.allApplications) {
let rows = await this.makeRows(student);
Expand Down
3 changes: 3 additions & 0 deletions src/web/src/components/application/Documentation.vue
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,9 @@ export default {
this.loadRequirementTypes();
this.applicationId = this.$route.params.id;
let storeApp = store.getters.selectedApplication;
await store.dispatch("clearApplication");
await store.dispatch("clearStudent");
if (this.$route.path.indexOf("/application/") >= 0) {
await store.dispatch("loadApplication", this.applicationId);
Expand Down

0 comments on commit a4d4d87

Please sign in to comment.