feat(Calendar): add weekdays props #5576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landluck
reviewed
Nov 6, 2023
| ], | ||
| }); | ||
| if (!Array.isArray(val)) { | ||
| const defaultWeeks = ['日', '一', '二', '三', '四', '五', '六']; |
There was a problem hiding this comment.
first-day-of-week 这个参数不能满足吗？我看他的需求是从一开始，first-day-of-week 设置为 1 不就行了吗
There was a problem hiding this comment.
他的需求想要的是能自定义星期，可以设置成英文等。
There was a problem hiding this comment.
多语言的问题先 hold 一下，不能通过 props 来解决。单个props配置也解决不了一个组件或者多语言的问题。另外实现有问题，一个是 ['日', '一', '二', '三', '四', '五', '六']; 这个配置出现了多次，另外一个是 ['日', '一', '二', '三', '四', '五', '六'] 这种静态配置没必要 observer。只有支持动态更新的数据 observer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5550