Merge pull request #1314 from yogeshojha/1310-can-use-note

Fix Not able to add todo from All Subdomains Section Fixes #1310
yogeshojha · Jul 20, 2024 · 7ee03c5 · 7ee03c5
2 parents 063c82e + 9586d0d
commit 7ee03c5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/web/api/views.py b/web/api/views.py
@@ -566,7 +566,6 @@ def post(self, request):
 		data = req.data
 
 		subdomain_id = data.get('subdomain_id')
-		scan_history_id = data.get('scan_history_id')
 		title = data.get('title')
 		description = data.get('description')
 		project = data.get('project')
@@ -577,10 +576,6 @@ def post(self, request):
 			note.title = title
 			note.description = description
 
-			if scan_history_id:
-				scan_history = ScanHistory.objects.get(id=scan_history_id)
-				note.scan_history = scan_history
-
 			# get scan history for subdomain_id
 			if subdomain_id:
 				subdomain = Subdomain.objects.get(id=subdomain_id)

diff --git a/web/recon_note/static/note/js/todo.js b/web/recon_note/static/note/js/todo.js
@@ -135,18 +135,20 @@ function populateTodofunction(project=null){
       'description': $_taskDescriptionText
     }
 
-    if ($("#scanHistoryIDropdown").val() && $("#scanHistoryIDropdown").val() != 'Choose Scan History...') {
-      data['scan_history'] = parseInt($("#scanHistoryIDropdown").val());
-    }
+    // if ($("#scanHistoryIDropdown").val() && $("#scanHistoryIDropdown").val() != 'Choose Scan History...') {
+    //   data['scan_history'] = parseInt($("#scanHistoryIDropdown").val());
+    // }
 
     if ($("#subdomainDropdown").val() != 'Choose Subdomain...') {
-      data['subdomain'] = parseInt($("#subdomainDropdown").val());
+      data['subdomain_id'] = parseInt($("#subdomainDropdown").val());
     }
 
     if (project) {
       data['project'] = project;
     }
 
+    console.log(data);
+
     fetch('/api/add/recon_note/', {
       method: 'post',
       headers: {

diff --git a/web/startScan/static/startScan/js/detail_scan.js b/web/startScan/static/startScan/js/detail_scan.js
@@ -1173,16 +1173,16 @@ function add_note_for_subdomain_handler(subdomain_id){
 	var title = document.getElementById('subdomainTodoTitle').value;
 	var description = document.getElementById('subdomainTodoDescription').value;
 	var project = document.querySelector('input[name="current_project"]').value;
-	var scan_id = parseInt(document.getElementById('summary_identifier_val').value);
 
 	data = {
 		'title': title,
 		'description': description,
 		'subdomain_id': subdomain_id,
 		'project': project,
-		'scan_history_id': scan_id
 	}
 
+	console.log(data);
+
 	fetch('/api/add/recon_note/', {
 		method: 'post',
 		headers: {