-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor main to use YAML parser and test with personal twitter bot #50
Open
erikkristoferanderson
wants to merge
7
commits into
ykdojo:main
Choose a base branch
from
erikkristoferanderson:refactor-print
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0c6ae92
refactor main and load_env plus just print for now
erikkristoferanderson 90c1ec2
delete __pycache__
erikkristoferanderson 37f3264
update .gitignore to ignore __pycach__/
erikkristoferanderson ea76b5e
add bearer-token
erikkristoferanderson 7fda952
change line processing logic
erikkristoferanderson 7062828
refactor to use yaml
erikkristoferanderson 7d24446
include PyYAML in requirements.txt
erikkristoferanderson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
API_KEY=something | ||
API_SECRET=something | ||
ACCESS_TOKEN=something | ||
ACCESS_TOKEN_SECRET=something | ||
BEARER_TOKEN=something |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
.env | ||
__pycache__/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
import os | ||
from dotenv import load_dotenv | ||
from dotenv import dotenv_values | ||
|
||
# takes environment variables from .env | ||
load_dotenv() | ||
config = dotenv_values(".env") | ||
|
||
def load_twitter_env(): | ||
consumer_key = os.getenv("API_KEY") | ||
consumer_secret = os.getenv("API_SECRET") | ||
access_token = os.getenv("ACCESS_TOKEN") | ||
access_token_secret = os.getenv("ACCESS_TOKEN_SECRET") | ||
return consumer_key, consumer_secret, access_token, access_token_secret | ||
consumer_key = config["API_KEY"] | ||
consumer_secret = config["API_SECRET"] | ||
access_token = config["ACCESS_TOKEN"] | ||
access_token_secret = config["ACCESS_TOKEN_SECRET"] | ||
bearer_token = config["BEARER_TOKEN"] | ||
return consumer_key, consumer_secret, access_token, access_token_secret, bearer_token |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
python-dotenv==0.20.0 | ||
tweepy==3.10.0 | ||
tweepy~=4.0 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like there might be a better solution here.
Maybe check if the first non-whitespace character is the hyphen or not, and if it is, remove all the whitespaces around it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So strip the line of white space and then check if the first character is a hyphen? That would work. But I'm not sure what you mean by "remove all the whitespaces around it". Still, I'll try making an edit.
Alternately, would it be better to use Python's yaml parser?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it might be better to use Python's YAML parser!