Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add body tags #3425

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Add body tags #3425

merged 6 commits into from
Oct 3, 2023

Conversation

moyeah
Copy link
Contributor

@moyeah moyeah commented Sep 29, 2023

Description

Added missing body tags to website get started and tutorial.

	modified:   website/docs/getting-started/build-a-sample-app.mdx
	modified:   website/versioned_docs/version-0.20/getting-started/build-a-sample-app.mdx
	modified:   website/versioned_docs/version-0.21/getting-started/build-a-sample-app.mdx
@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Visit the preview URL for this PR (updated for commit ada788c):

https://yew-rs--pr3425-add-body-tags-uzc9cer4.web.app

(expires Sat, 07 Oct 2023 18:35:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@moyeah moyeah mentioned this pull request Sep 29, 2023
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please the body tag in and not ?

They aren't really needed as Yew will add one if it needs to. It doesn't hurt to add them though

website/docs/getting-started/build-a-sample-app.mdx Outdated Show resolved Hide resolved
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ranile ranile requested a review from futursolo October 2, 2023 22:13
@ranile ranile requested a review from cecton October 2, 2023 22:14
@futursolo futursolo merged commit ede6d91 into yewstack:master Oct 3, 2023
6 checks passed
@moyeah moyeah deleted the add-body-tags branch October 3, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants