Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation typo - function components introduction.mdx #3417

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devfbe
Copy link

@devfbe devfbe commented Sep 24, 2023

Description

Just add a missing 'l' to the closing HelloWorld tag in the function components documentation (introduction.mdx)

Checklist

  • I have reviewed my own code
  • I have added tests

@devfbe devfbe force-pushed the devfbe-fix-typo-in-function-components branch from ed49565 to 11d2560 Compare September 24, 2023 20:28
Just add a missing 'l' to the closing HelloWorld tag in the function components documentation (introduction.mdx)
Also, indent level has been changed because prettier now recognizes the
XHTML structure and the indention was not as expected.
@devfbe devfbe force-pushed the devfbe-fix-typo-in-function-components branch from 11d2560 to adc1883 Compare September 24, 2023 20:33
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit adc1883):

https://yew-rs--pr3417-devfbe-fix-typo-in-f-bilc6kkk.web.app

(expires Sun, 01 Oct 2023 20:41:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this.

However, since v0.21 has been released, there is a new docs version.
Could you please fix the example in the v0.21 version as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants