-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to support Django 4.2 #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - just a few small changes. And then does it make sense to remove _alpha
from this branch name (since we're using it to reference from ycharts
)?
It does, but I'm unsure if it is possible to do without creating another branch. I added |
Yeah, I think it's worth it though. Even if you need to create a new branch and then delete the old one. |
@kbaskett248 I've updated the PR a little. Pretty much dev-only changes. But I'd like you to see if something may be off. It should work the same. Also, this will merge into a branch without |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look awesome! I'm glad you went ahead and added the pre-commit
and github actions configuration. And it's nice to know that this supports up to Django 5 now.
I did talk to Fox about possibly removing this at some point, and he didn't think it was worth it. So we'll be supporting this for the foreseeable future. All your changes here will make that easier. Great job!
Also, really smart way to change the branch name!
.github/workflows/main.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
.pre-commit-config.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smart!
Add support for Django 4.2 and remove it for Django 3.2 and below