Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support Django 4.2 #4

Merged
merged 9 commits into from
Feb 15, 2024
Merged

Update to support Django 4.2 #4

merged 9 commits into from
Feb 15, 2024

Conversation

jpintor52
Copy link

Add support for Django 4.2 and remove it for Django 3.2 and below

Copy link

@kbaskett248 kbaskett248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - just a few small changes. And then does it make sense to remove _alpha from this branch name (since we're using it to reference from ycharts)?

setup.py Outdated Show resolved Hide resolved
suit/templatetags/suit_list.py Outdated Show resolved Hide resolved
suit/tests/models.py Show resolved Hide resolved
@kbaskett248 kbaskett248 assigned jpintor52 and unassigned kbaskett248 Feb 14, 2024
@jpintor52
Copy link
Author

And then does it make sense to remove _alpha from this branch name [...] ?

It does, but I'm unsure if it is possible to do without creating another branch. I added alpha because I was unsure if it was going to work at all.

@kbaskett248
Copy link

And then does it make sense to remove _alpha from this branch name [...] ?

It does, but I'm unsure if it is possible to do without creating another branch. I added alpha because I was unsure if it was going to work at all.

Yeah, I think it's worth it though. Even if you need to create a new branch and then delete the old one.

@jpintor52 jpintor52 changed the base branch from v1_django32 to v1_django42 February 14, 2024 21:21
@jpintor52 jpintor52 marked this pull request as ready for review February 14, 2024 22:33
@jpintor52
Copy link
Author

@kbaskett248 I've updated the PR a little. Pretty much dev-only changes. But I'd like you to see if something may be off. It should work the same. Also, this will merge into a branch without _alpha

@jpintor52 jpintor52 assigned kbaskett248 and unassigned jpintor52 Feb 14, 2024
Copy link

@kbaskett248 kbaskett248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look awesome! I'm glad you went ahead and added the pre-commit and github actions configuration. And it's nice to know that this supports up to Django 5 now.

I did talk to Fox about possibly removing this at some point, and he didn't think it was worth it. So we'll be supporting this for the foreseeable future. All your changes here will make that easier. Great job!

Also, really smart way to change the branch name!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart!

@kbaskett248 kbaskett248 assigned jpintor52 and unassigned kbaskett248 Feb 15, 2024
@jpintor52 jpintor52 merged commit ede15fb into v1_django42 Feb 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants