New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bug with Facet Check in Suggest #38

Open

anthonyp97 wants to merge 1 commit into master from fix_facets_updated_check

anthonyp97 commented Nov 12, 2024

Overview

Bug on line with “facets_updated = facets != old_facets” because old_facets is in the structure:

[
{'key': 'feature_needed', 'value': 'metric'}, 
{'key': 'always_display', 'value': True}
]

while facets is in the structure: ['feature_needed', 'always_display'].
Should update this to be “facets_updated = facet_dicts != old_facets”.


          fix facet check

bc6e36a

nathanielw44 mentioned this pull request

Align on facet variable naming convention #39

Open

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet