-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update schemas and submodule for v0.4.0 #38
Conversation
…n to CONTRIBUTION.md code block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please read the contributing documentation: https://github.com/yazi-rs/schemas/blob/main/CONTRIBUTING.md#updating-for-a-new-yazi-release. It does not look like you have gone through the commit changes fully. I didn't go through all of the commits so far but here are the first things I noticed. Please keep going through them as instructed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugin.spotters
was not added, see sxyazi/yazi@1f32601#diff-62c176c03cb77cb11e287cf9fe420fe603abd55296017d7323328e37eb056818L92.
Eh, I'll merge and fix the rest myself so we can get this through quickly. Thanks for contributing! |
@uncenter thanks a lot for the time and sorry for all the trouble. I'll make sure to improve myself on upcoming contributions. |
No worries! You did great thank you. |
Migrating to [email protected] mentioned on Issue#1772:
update-submodules.sh
pnpm format
select
withpick
, addedspot
select
withpick
, addedmode
, addedconfirm
select
withpick
, added PR#34 from the author Tyarel8 as well, since it fits to this PR