Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update schemas and submodule for v0.4.0 #38

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

lamteteeow
Copy link
Contributor

@lamteteeow lamteteeow commented Dec 8, 2024

Migrating to [email protected] mentioned on Issue#1772:

  • Ran update-submodules.sh
  • Ran pnpm format
  • keymap.json: replaced select with pick, added spot
  • theme.json: replaced select with pick, added mode, added confirm

confirm has 2 properties that are not clear at the moment: content and list so I set them both to any type. If this could be cleared up, I could add some changes. I am assuming them to both have { "$ref": "#/$defs/style" }.

  • yazi.json: replaced select with pick, added PR#34 from the author Tyarel8 as well, since it fits to this PR
  • CONTRIBUTING.md: added a minor lang-description to the code block because of markdown linter's warning

@lamteteeow lamteteeow changed the title fix(schemas): updated schemas and submodule for v0.4.0, minor addition to CONTRIBUTION.md code block fix(schemas): updated schemas and submodule for v0.4.0, minor addition to CONTRIBUTING.md code block Dec 8, 2024
@uncenter uncenter changed the title fix(schemas): updated schemas and submodule for v0.4.0, minor addition to CONTRIBUTING.md code block feat: update schemas and submodule for v0.4.0 Dec 9, 2024
schemas/yazi.json Show resolved Hide resolved
schemas/theme.json Show resolved Hide resolved
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the contributing documentation: https://github.com/yazi-rs/schemas/blob/main/CONTRIBUTING.md#updating-for-a-new-yazi-release. It does not look like you have gone through the commit changes fully. I didn't go through all of the commits so far but here are the first things I noticed. Please keep going through them as instructed.

schemas/theme.json Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lamteteeow lamteteeow requested a review from uncenter December 10, 2024 19:49
schemas/yazi.json Show resolved Hide resolved
schemas/yazi.json Show resolved Hide resolved
@uncenter
Copy link
Member

Eh, I'll merge and fix the rest myself so we can get this through quickly. Thanks for contributing!

@uncenter uncenter merged commit aac8898 into yazi-rs:main Dec 11, 2024
1 check passed
@lamteteeow
Copy link
Contributor Author

@uncenter thanks a lot for the time and sorry for all the trouble. I'll make sure to improve myself on upcoming contributions.

@uncenter
Copy link
Member

No worries! You did great thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants