[2.0] Adding support for PDO::ATTR_STATEMENT_CLASS #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajra
changed the title
|
Looks good but introduces a breaking change. Anyways, just in time for v2 of the package so it's good to go :). Thanks a lot! |
|
Okay, after testing again after merge. It seems like this broke the implementation of I removed the v2 tag I released while digging the issue. Failing codes for ref: https://github.com/yajra/laravel-oci8/blob/master/src/Oci8/Oci8Connection.php#L277 |
|
Sorry had to revert this as it fails the code ref above. Please submit another PR if you can that does not break that implementation or do you have any suggestions on he we can fix it? Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggested fix for #69