XWIKI-22723: Warning message for application move has duplicated icons #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed the extra icon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22723
Changes
Description
Clarifications
$services.icon.renderin this XML's templates. However, those are for hardcodded box. Those will be removed at the same time as the boxes are moved to a standard macro use, see XWIKI-22433Screenshots & Video
After the changes. We can see on the picture below that the duplicated icon is no more and things still look alright.
Executed Tests
None, this is a minor UI change on a non interactive element. Moreover, this regression on UI was found "by hand" and not reported by automated tests, so there's a high chance that the tests for this element are strict enough to be broken by this change.
Expected merging strategy