XWIKI-21629: The step order displayed in inline edit is not consistent with the order from objects editor #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t with the order from objects editor * Removed the operation on the order number that caused confusion
…t with the order from objects editor * Removed similar operations, I searched in the module all uses of `mathtool`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21629
Changes
Description
mathtool.Screenshots & Video
On this first screenshot, we can see that the list displayed now starts as expected with the order 0.
One of the annex changes is to make sure the options when creating and editing a step are displayed from 0 too. Just changing the displayed order does not break anything, those options had a non visible order that was used programatically and contained the correct value already.
Executed Tests
After building the changes, successfully built the docker tests
mvn clean install -f xwiki-platform-core/xwiki-platform-tour/xwiki-platform-tour-test/xwiki-platform-tour-test-dockerExpected merging strategy