Uppercase first character of a translation key #1
Conversation
| @@ -58,7 +58,7 @@ ckeditor.admin.reset.confirmation=Are you sure you want to restore the default c | |||
| ckeditor.plugin.link.options=Options | |||
| ckeditor.plugin.link.anchor=Anchor | |||
| ckeditor.plugin.link.queryString=Query String | |||
| ckeditor.plugin.link.defaultLabel=type the link label | |||
| ckeditor.plugin.link.defaultLabel=Type the link label | |||
There was a problem hiding this comment.
This text (and the link label in general) is inserted in-line, most probably in the middle of a sentence so I'm not convinced that it should start with an upper case letter.
There was a problem hiding this comment.
https://snag.gy/ioyfVq.jpg See? "Find a page" with a uppercase and "type the link label" with lowercase but I understand what you mean ... You can reject my PR if you wish :-)
There was a problem hiding this comment.
Indeed https://snag.gy/ioyfVq.jpg needs to be fixed (either in code with a StringUtils.capitalize() or in transaltion).
There was a problem hiding this comment.
Marius refers that if you insert a label using the modal and leave the default value it will get inserted (in most cases) inside a phrase, not at the beginning (to justify the capitalization), see
Now question A is: how many users edit the link label inside the modal vs. inside the editor textarea?
There was a problem hiding this comment.
Question B: do we need to provide a default value? or can we just use a placeholder for the input?
- Depends on the answer to A, since if we add a link without a value, it will be hard for the user to know where the link starts/ends.
- A solution would be to make the "Display Text" mandatory, but this will break cases when link displays the page name if no link value is provided.
There was a problem hiding this comment.
If the same key is used for 2 different use cases then we should probably introduce a new key.
There was a problem hiding this comment.
It's not for 2 different use cases, the key is used as value so it gets inserted inside the text.
No description provided.