Work on new features from 1.4.1 #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented (with appropriate tests) - downloading of images from an input stream - isCached method - getSampleSize - bumpOnDisk - getImageDimensions - invalidateFileSystemUri (no test) - calculateAndSaveImageDetails - getImageDimensionsFromDisk - getDetailsPrioritizable - getBitmapSynchronouslyFromDisk - testCalculateAndSaveImageDetails - getDecodePrioritizable - Discussed progress with Jamie
- Included teardown in tests - Implemented journaling evictions (including tests) - Basic implementation of image details guarantee (needs to be thrown onto another thread) - testGetSampleSizeWithNoDetailsSaved() - Fixed critical bug with journaling on database system and added test for it - Refactored disk cache initialization into init method (instead of constructor) - Closed cursors that were being used in ImageSystemDatabase - Added test for ensuring journaled data persists correct order - Added test for removeLRU method in ImageSystemDatabase (including bump functionality) - Implemented testNoLruEvictionsForIncompleteDownloads - Removed AUTOINCREMENT from table definition
- Added SHOULD_RUN flag to AdvancedMemoryCacherTests - Fixed some typos - Re-wrote ViewDimensionsUtil - Minor refactor of DisplayUtility - Added expiry to ImageSystemDatabase - Refactored ImageSystemDatabase - Fixed potential problem with missing entry ID - Table object now returns appropriate values from DB methods (insert/update/delete)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.