This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Add support for simple auth + account generation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nkramer44 <[email protected]>
sappenin
approved these changes
Feb 10, 2020
| /** | ||
| * Jackson deserializer for {@link PaymentPointer}. | ||
| */ | ||
| public class PaymentPointerDeserializer extends StdDeserializer<PaymentPointer> { |
There was a problem hiding this comment.
This is fine to be located here for now, but we should put this into Quilt since payment pointer lives there.
src/main/java/org/interledger/spsp/server/grpc/services/AccountRequestResponseConverter.java
Outdated
Show resolved
Hide resolved
src/test/java/org/interledger/spsp/server/grpc/AccountGrpcHandlerTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/interledger/spsp/server/grpc/AccountGrpcHandlerTests.java
Show resolved
Hide resolved
src/test/java/org/interledger/spsp/server/grpc/AccountGrpcHandlerTests.java
Show resolved
Hide resolved
theotherian
reviewed
Feb 10, 2020
| Optional<String> credentials = maybeAuthToken.toString().isEmpty() ? | ||
| Optional.empty() : Optional.of(maybeAuthToken.toString()); | ||
|
|
||
| AccountSettings accountSettings = newAccountService.createAccount(credentials, createAccountRequest); |
There was a problem hiding this comment.
This and the lines above it could be rewritten a bit more concisely as:
newAccountService.createAccount(authToken.map(t -> t.substring(t.indexOf(" ") + 1), createAccountRequest)
The authToken.map should return what you want or an empty optional.
theotherian
reviewed
Feb 10, 2020
|
|
||
| // Create account on the connector | ||
| AccountSettings returnedAccountSettings = newAccountService.createAccount(request); | ||
| AccountSettings returnedAccountSettings = newAccountService.createAccount(credentials, request); |
There was a problem hiding this comment.
Same here as with the last optional. It may be helpful to encapsulate this behavior in a class somewhere.
theotherian
approved these changes
Feb 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide developers with an easier way to interact with Xpring's ILP infrastructure.
Developers can now create an account through Hermes, which will generate both an account id as well as a
AuthType.SIMPLEauth token, and pass the unencrypted auth token back after the account has been created on the connector. Developers can simply send a POST request to Hermes/accountsand will no longer have to create an account through Hermes using a JWT.Developers also have the ability to specify their own simple auth token, which allows for a greater breadth of auth providers at the application level.
All account-related endpoints will also now return a payment pointer, based on the SPSP url of the receiver that is currently wired up.
These changes shouldn't break any existing ILP wallet functionality, as Hermes still supports JWT passthrough, and all response object modifications were additive.