This repository has been archived by the owner on Feb 8, 2023. It is now read-only.
forked from mars-project/mars
-
Notifications
You must be signed in to change notification settings - Fork 4
Feature: collect subtask info into yaml format #70
Open
hoarjour
wants to merge
1
commit into
xorbitsai:master
Choose a base branch
from
hoarjour:subtask_vis
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UranusSeven
reviewed
Nov 22, 2022
UranusSeven
reviewed
Nov 23, 2022
UranusSeven
reviewed
Nov 25, 2022
aresnow1
reviewed
Nov 29, 2022
|
||
class TaskInfoCollectorActor(mo.Actor): | ||
|
||
def __init__(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try this:
mars_temp_dir = os.path.dirname(os.environ.get(MARS_LOG_PATH_KEY))
self.yaml_root_dir = os.path.join(mars_temp_dir, "mars_task_infos")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add logs to tell the yaml locations.
aresnow1
reviewed
Nov 29, 2022
UranusSeven
force-pushed
the
subtask_vis
branch
from
February 8, 2023 04:24
9bdc187
to
de560e8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Collect subtask graph structure and runtime subtask information
Related issue number
Fixes #xxxx
Check code requirements