Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix register model list error #2189

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

amumu96
Copy link
Contributor

@amumu96 amumu96 commented Aug 29, 2024

Fix the bug that even if the registration fails, the model is still written to the registration list

@XprobeBot XprobeBot added the bug Something isn't working label Aug 29, 2024
@XprobeBot XprobeBot added this to the v0.14 milestone Aug 29, 2024
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit db2b846 into xorbitsai:main Aug 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants