feat: add XEN-L006 (xod/uart additions) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - [in] RST :: Pulse - Empty the accumulated string line and start over | ||
|
|
||
| - [out] LINE :: String - Accumulated line | ||
| - [out] LINE :: Pulse - Fires on a new accumulated line |
There was a problem hiding this comment.
Two pins can't have the same label. Did you mean something like UPD?
brusherru
requested changes
Sep 14, 2018
|
|
||
| ## List of nodes | ||
|
|
||
| ### accumulate-line |
There was a problem hiding this comment.
Hm... we have such node in xod/stream.
And also it has very important input CAP (capacity), which is skipped here.
Maybe better to do a handy node accumulate-line in xod/stream library, which will be a composition of nodes accumulate-string and pass-until?
| - [in] READ :: Pulse - Triggers read of a string line ??? | ||
| - [in] READ :: Bool - The true value turns on the stream of the string lines ??? | ||
|
|
||
| - [out] LINE :: String - String line that is read ??? |
There was a problem hiding this comment.
The same issue with capacity 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
accumulate-lineandreadnodes.