Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the credentials fetching code and an example program. #7

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

schmidtw
Copy link
Member

No description provided.

@guardrails
Copy link

guardrails bot commented Sep 25, 2023

⚠️ We detected 1 security issue in this pull request:

Insecure Network Communication (1)
Severity Details Docs
Medium Title: Insecure SSL/TLS versions allowed
📚

More info on how to fix Insecure Network Communication in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #7 (5fd793b) into main (b80460e) will decrease coverage by 1.38%.
The diff coverage is 90.52%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   93.61%   92.23%   -1.38%     
==========================================
  Files           6        9       +3     
  Lines         501      902     +401     
==========================================
+ Hits          469      832     +363     
- Misses         22       51      +29     
- Partials       10       19       +9     
Flag Coverage Δ
unittests 92.23% <90.52%> (-1.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/credentials/options.go 85.98% <85.98%> (ø)
internal/credentials/credentials.go 90.04% <90.04%> (ø)
internal/credentials/internal_options.go 100.00% <100.00%> (ø)

@schmidtw schmidtw merged commit f8087d3 into main Sep 25, 2023
14 of 15 checks passed
@schmidtw schmidtw deleted the add-cred-fetch branch September 25, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant