Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the coverage for credentials. #24

Merged
merged 5 commits into from
May 17, 2024
Merged

Conversation

schmidtw
Copy link
Member

@schmidtw schmidtw commented Jan 1, 2024

No description provided.

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.74%. Comparing base (69b4bdf) to head (9e07fc1).
Report is 240 commits behind head on main.

Current head 9e07fc1 differs from pull request most recent head 104c2aa

Please upload reports for the commit 104c2aa to get more accurate results.

Files Patch % Lines
cmd/xmidt-agent/credentials.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #24       +/-   ##
===========================================
+ Coverage   69.94%   80.74%   +10.79%     
===========================================
  Files          35       27        -8     
  Lines        2545     1999      -546     
===========================================
- Hits         1780     1614      -166     
+ Misses        713      357      -356     
+ Partials       52       28       -24     
Flag Coverage Δ
unittests 80.74% <90.90%> (+10.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schmidtw schmidtw requested a review from denopink May 17, 2024 20:47
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🍻

@schmidtw schmidtw merged commit c94f6ff into main May 17, 2024
14 checks passed
@schmidtw schmidtw deleted the improve-credentials-tests branch May 17, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants