Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support disableable qos queue trimming #210

Closed
wants to merge 1 commit into from

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Aug 1, 2024

  • disableable qos queue trimming
  • this will match parodus's default behavior
    • no queue trimming

- disableable qos queue trimming
- this will match parodus's default behavior
  - no queue trimming
@denopink denopink added the enhancement improvement or small functionality added to an existing feature label Aug 1, 2024
@denopink denopink requested review from johnabass and ilawjr August 1, 2024 21:13
@denopink denopink self-assigned this Aug 1, 2024
@denopink denopink requested a review from schmidtw August 1, 2024 21:15
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.84%. Comparing base (31387eb) to head (55d3d62).

Files Patch % Lines
internal/wrphandlers/qos/internal_options.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   76.94%   76.84%   -0.10%     
==========================================
  Files          75       75              
  Lines        4550     4548       -2     
==========================================
- Hits         3501     3495       -6     
- Misses        851      853       +2     
- Partials      198      200       +2     
Flag Coverage Δ
unittests 76.84% <50.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denopink denopink closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvement or small functionality added to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant