patch: match parodus' default qos queue behavior #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
denopink
commented
Aug 1, 2024
•
denopink
commented
- disable individual message size validation
- increase the default for max_queue_bytes (required for qa testing)
denopink
added
bug
denopink
force-pushed
the
denopink/patch/update-default-config-to-support-qa
branch
from
3681159 to
9ef92bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 76.94% 77.01% +0.06%
==========================================
Files 75 75
Lines 4550 4550
==========================================
+ Hits 3501 3504 +3
+ Misses 851 848 -3
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
denopink
force-pushed
the
denopink/patch/update-default-config-to-support-qa
branch
from
9ef92bb to
ef0190e
Compare
denopink
changed the title
denopink
force-pushed
the
denopink/patch/update-default-config-to-support-qa
branch
from
ef0190e to
37661d5
Compare
denopink
commented
Aug 1, 2024
| @@ -127,8 +127,6 @@ mock_tr_181: | |||
| xmidt_agent_crud: | |||
| service_name: xmidt_agent | |||
| qos: | |||
There was a problem hiding this comment.
disable individual message size validation by removing max_message_bytes
denopink
force-pushed
the
denopink/patch/update-default-config-to-support-qa
branch
from
37661d5 to
4f1f3f1
Compare
denopink
commented
Aug 1, 2024
| @@ -127,8 +127,7 @@ mock_tr_181: | |||
| xmidt_agent_crud: | |||
| service_name: xmidt_agent | |||
| qos: | |||
| max_queue_bytes: 1048576 # 1 * 1024 * 1024 // 1MB max/queue, | |||
| max_message_bytes: 262144 # 256 * 1024 // 256 KB | |||
| max_queue_bytes: 104857600 # 100 * 1024 * 1024 // 100MB max/queue, | |||
There was a problem hiding this comment.
increase the default for max_queue_bytes (required for qa testing)
- disable individual message size validation - increase the default for max_queue_bytes (required for qa testing)
denopink
force-pushed
the
denopink/patch/update-default-config-to-support-qa
branch
from
4f1f3f1 to
4139f13
Compare
ilawjr
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.