Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: mocktr181 - adding missing statusCode and update content type #205

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

denopink
Copy link
Contributor

  • keep contenttype consistent with other wrp.handlers
  • include a statusCode for bad mocktr181 cmds

@denopink denopink added the bug Something isn't working label Jul 31, 2024
@denopink denopink requested review from schmidtw and johnabass July 31, 2024 21:58
@denopink denopink self-assigned this Jul 31, 2024
- keep contenttype consistent with other wrp.handlers
- include a `statusCode` for bad mocktr181 cmds
@denopink denopink force-pushed the denopink/patch/standardize-mocktr181-response branch from 53c11a6 to dee53b4 Compare July 31, 2024 21:58
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.88%. Comparing base (850efb6) to head (dee53b4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   76.97%   76.88%   -0.09%     
==========================================
  Files          75       75              
  Lines        4542     4542              
==========================================
- Hits         3496     3492       -4     
- Misses        848      852       +4     
  Partials      198      198              
Flag Coverage Δ
unittests 76.88% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@johnabass johnabass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good consistency

@denopink denopink merged commit 768d15f into main Jul 31, 2024
17 of 18 checks passed
@denopink denopink deleted the denopink/patch/standardize-mocktr181-response branch July 31, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants