feat: count ping as websocket activity #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
denopink
commented
Jul 31, 2024
denopink
commented
- count ping as websocket activity
- lack of activity will trigger inactivityTimeout, causing the websocket connection to close and reconnect
- count ping as websocket activity - lack of activity will trigger inactivityTimeout, causing the websocket connection to close and reconnect
denopink
added
the
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
+ Coverage 76.97% 77.01% +0.04%
==========================================
Files 75 75
Lines 4542 4550 +8
==========================================
+ Hits 3496 3504 +8
Misses 848 848
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
denopink
commented
Jul 31, 2024
| @@ -289,22 +291,32 @@ func (ws *Websocket) run(ctx context.Context) { | |||
| // Read loop | |||
| for { | |||
| var msg wrp.Message | |||
| ctx, cancel := context.WithTimeout(ctx, ws.inactivityTimeout) | |||
| typ, reader, err := ws.conn.Reader(ctx) | |||
There was a problem hiding this comment.
we want to include the activity from pings. that requires us to manually trigger a timeout.
Otherwise, the device will reconnect in intervals of ws.inactivityTimeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.