Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: empty names field causes mockt181's GET to panic #202

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

denopink
Copy link
Contributor

  • empty names field causes mockt181's GET to panic (name[len(name)-1] == '.')

- empty names field causes mockt181's GET to panic (`name[len(name)-1] == '.'`)
@denopink denopink added the bug Something isn't working label Jul 29, 2024
@denopink denopink self-assigned this Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.03%. Comparing base (bb0db20) to head (1a60019).

Files Patch % Lines
internal/wrphandlers/mocktr181/handler.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   76.91%   77.03%   +0.12%     
==========================================
  Files          75       75              
  Lines        4540     4542       +2     
==========================================
+ Hits         3492     3499       +7     
+ Misses        851      845       -6     
- Partials      197      198       +1     
Flag Coverage Δ
unittests 77.03% <0.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denopink denopink requested a review from piccione99 July 29, 2024 16:12
@denopink denopink merged commit 850efb6 into main Jul 29, 2024
17 of 19 checks passed
@denopink denopink deleted the denopink/patch/mocktr181-empty-name-panics-GET branch July 29, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants