Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(#188): add headers from original request to redirects" #190

Closed
wants to merge 2 commits into from

Conversation

denopink
Copy link
Contributor

Reverts #189

#188 is likely a non-issue

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.50%. Comparing base (7e28f22) to head (7724894).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
- Coverage   76.96%   74.50%   -2.47%     
==========================================
  Files          75       75              
  Lines        4510     4506       -4     
==========================================
- Hits         3471     3357     -114     
- Misses        839      942     +103     
- Partials      200      207       +7     
Flag Coverage Δ
unittests 74.50% <ø> (-2.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denopink denopink marked this pull request as draft July 15, 2024 22:00
@denopink
Copy link
Contributor Author

update: we were able to reproduce the issue. Getting other teammates involved #188 (comment)

@denopink
Copy link
Contributor Author

revert no longer needed: #188 (comment)

@denopink denopink closed this Jul 15, 2024
@denopink denopink deleted the revert-189-fix/188/send_headers branch July 15, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant