patch: add missing mocktr181's response fields #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denopink
added
bug
denopink
commented
Jul 8, 2024
denopink
force-pushed
the
denopink/patch/mocktr181-response-issing-statusCode
branch
from
24cf454 to
48f0f25
Compare
- add the missing `statusCode` field to mocktr181's response payload - add the expected values for the response fields `Command` and `Names` - add missing `Success` message for successful `gets` and `patches`
denopink
force-pushed
the
denopink/patch/mocktr181-response-issing-statusCode
branch
from
48f0f25 to
d556a1d
Compare
- add the missing `statusCode` field to mocktr181's response payload - add the expected values for the response fields `Command` and `Names` - add missing `Success` message for successful `gets` and `patches`
…ttps://github.com/xmidt-org/xmidt-agent into denopink/patch/mocktr181-response-issing-statusCode
denopink
changed the title
statusCode to mocktr181's response payload
denopink
commented
Jul 10, 2024
| @@ -173,32 +178,37 @@ func (h Handler) get(names []string) (int64, []byte, error) { | |||
| Value: mockParameter.Value, | |||
| DataType: mockParameter.DataType, | |||
| Attributes: mockParameter.Attributes, | |||
| Message: "Success", | |||
| Count: 1, | |||
There was a problem hiding this comment.
note: non-wildcard gets will always have a Count of 1 (based on parodus2ccsp and wdmp-c)
schmidtw
requested changes
Jul 10, 2024
…ttps://github.com/xmidt-org/xmidt-agent into denopink/patch/mocktr181-response-issing-statusCode
schmidtw
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
statusCodefield to mocktr181's response payloadCommandandNamesSuccessmessage for successfulgetsandpatchesCountfield to mocktr181's response payload