feat: optimize qos queue trimming without heap.Init() (O(n*log(n))
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 100% test cover for internal/wrphandlers/qos - optimize priorityQueue.trim() to remove messages with the lowest qos by leveraging two priority queues (1 prioritizing the highest QOS and the other prioritizing the lowest QOS) - avoid the use of `heap.Init()` O(n) - priorityQueue.trim() is O(n*log(n))
denopink
force-pushed
the
denopink/feat/optimize-qos-trim-v2
branch
from
f86df03 to
5a4ec32
Compare
denopink
changed the title
O(n*log(n))heap.Init() (O(n*log(n))
denopink
commented
Jun 5, 2024
| priorityQueue | ||
| } | ||
|
|
||
| // Dequeue returns the message with the lowest QualityOfService. |
There was a problem hiding this comment.
Suggested change
| // Dequeue returns the message with the lowest QualityOfService. | |
| // trim removes the message with the lowest QualityOfService. |
|
|
||
| // heap.Interface related implementation https://pkg.go.dev/container/heap#Interface | ||
|
|
||
| // Prioritize messages with the lowest QualityOfService. |
There was a problem hiding this comment.
Suggested change
| // Prioritize messages with the lowest QualityOfService. | |
| // Less prioritizes messages with the lowest QualityOfService. |
| } | ||
|
|
||
| // heap.Interface related implementations https://pkg.go.dev/container/heap#Interface | ||
| func (pq *priorityQueue) Len() int { return len(pq.queue) } |
There was a problem hiding this comment.
Suggested change
| func (pq *priorityQueue) Len() int { return len(pq.queue) } | |
| func (pq *priorityQueue) Len() int { return len(pq.queue) } |
|
|
||
| func (pq *priorityQueue) Less(i, j int) bool { | ||
| iItem, jItem := pq.queue[i], pq.queue[j] | ||
| // Prioritize messages with the highest QualityOfService. |
There was a problem hiding this comment.
Suggested change
| // Prioritize messages with the highest QualityOfService. | |
| // Less prioritizes messages with the highest QualityOfService. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
heap.Init()O(n)