Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove inline default config #142

Closed
wants to merge 14 commits into from
Closed

remove inline default config #142

wants to merge 14 commits into from

Conversation

piccione99
Copy link
Contributor

embed config file

please look over for appropriate comments explaining the config

@piccione99 piccione99 requested review from schmidtw and denopink May 22, 2024 19:15
@guardrails GuardRails
Copy link

guardrails bot commented May 22, 2024 •
edited
Loading

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

schmidtw
schmidtw requested changes May 22, 2024
View reviewed changes
cmd/xmidt-agent/config.go Outdated Show resolved Hide resolved
cmd/xmidt-agent/config.go Outdated Show resolved Hide resolved
cmd/xmidt-agent/default-config.yaml Show resolved Hide resolved
denopink
denopink requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few suggestions, looking good so far 🙂

denopink
denopink approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🍻

@schmidtw schmidtw enabled auto-merge May 23, 2024 18:57
@schmidtw schmidtw disabled auto-merge May 23, 2024 18:58
@schmidtw schmidtw enabled auto-merge May 23, 2024 19:08
@schmidtw schmidtw disabled auto-merge May 23, 2024 20:40
@schmidtw schmidtw closed this May 23, 2024
@piccione99 piccione99 deleted the config branch May 23, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denopink denopink denopink approved these changes

@schmidtw schmidtw schmidtw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piccione99 @schmidtw @denopink