Skip to content

Commit

Permalink
modify webhooks package to not use logging package functions (#469)
Browse files Browse the repository at this point in the history
  • Loading branch information
kristinapathak authored Apr 17, 2020
1 parent e1656cf commit a0fffba
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## [v1.8.1]
- change webhooks package to not use `logging` functions [#469](https://github.com/xmidt-org/webpa-common/pull/469)

## [v1.8.0]
- upgrade wrp-go version to v3.0.1 for subpackages convey and device [#460](https://github.com/xmidt-org/webpa-common/pull/460)
- Increase reliability of travis unit tests by refactoring racy testLogger [#462](https://github.com/xmidt-org/webpa-common/pull/462)
Expand Down
5 changes: 3 additions & 2 deletions webhook/aws/sns.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"time"

"github.com/go-kit/kit/log"
"github.com/go-kit/kit/log/level"
"github.com/gorilla/mux"
"github.com/miekg/dns"
"github.com/spf13/viper"
Expand Down Expand Up @@ -168,8 +169,8 @@ func (ss *SNSServer) Initialize(rtr *mux.Router, selfUrl *url.URL, soaProvider s
logger = logging.DefaultLogger()
}

ss.errorLog = logging.Error(logger)
ss.debugLog = logging.Debug(logger)
ss.errorLog = log.WithPrefix(logger, level.Key(), level.ErrorValue())
ss.debugLog = log.WithPrefix(logger, level.Key(), level.DebugValue())

ss.metrics = ApplyMetricsData(registry)
ss.snsNotificationReceivedChan = ss.SNSNotificationReceivedInit()
Expand Down

0 comments on commit a0fffba

Please sign in to comment.