Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update code layout be to consistent with our newer servers (skeleton layout) #604

Merged

Conversation

denopink
Copy link
Contributor

No description provided.

@denopink denopink force-pushed the denopink/refactor/move-to-skeleton-standard branch from 8413214 to 0f52b7d Compare December 18, 2024 17:16
@@ -0,0 +1,95 @@
// SPDX-FileCopyrightText: 2022 Comcast Cable Communications Management, LLC
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved setup.go to internal/setup.go

…(skeleton layout)

- easy to revert back if we wanted
@denopink denopink force-pushed the denopink/refactor/move-to-skeleton-standard branch from 0f52b7d to 86b7d10 Compare December 18, 2024 17:29
@denopink denopink merged commit 06973e7 into feat/caduceus-updates Dec 18, 2024
14 checks passed
@denopink denopink deleted the denopink/refactor/move-to-skeleton-standard branch December 18, 2024 17:33
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

Project coverage is 43.36%. Comparing base (0a89a21) to head (86b7d10).
Report is 3 commits behind head on feat/caduceus-updates.

Files with missing lines Patch % Lines
internal/setup.go 0.00% 35 Missing ⚠️
cmd/tr1d1um/main.go 0.00% 14 Missing ⚠️
internal/primaryHandler.go 0.00% 3 Missing ⚠️
internal/routes.go 0.00% 3 Missing ⚠️
internal/auth.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feat/caduceus-updates     #604   +/-   ##
======================================================
  Coverage                  43.36%   43.36%           
======================================================
  Files                         16       16           
  Lines                       1229     1229           
======================================================
  Hits                         533      533           
  Misses                       684      684           
  Partials                      12       12           
Flag Coverage Δ
unittests 43.36% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant