Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a metrics package and moved metrics files to package #428

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

maurafortino
Copy link
Contributor

What's Included:

  • created a metrics package
    • moved metrics.go, metrics_test.go and anclaHelper.go files to the metrics package
    • moved CaduceusMetricsRegistry interface to metrics.go file (import issues if left in main)
    • moved CreateOutbounderMetrics to outboundSender.go (import issues if left in metrics package)
  • moved error reasons constants to http.go (all but one are only related to http.go - only error related to metrics is network error)
  • all other updates are just updating files with the metrics package and differentiating between caduceus metrics package and gokit metrics package.

Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a quick change. otherwise, lgtm!

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (denopink/chore/restructure-code-base@fbffc52). Click here to learn what that means.
The diff coverage is n/a.

@@                           Coverage Diff                           @@
##             denopink/chore/restructure-code-base     #428   +/-   ##
=======================================================================
  Coverage                                        ?   66.12%           
=======================================================================
  Files                                           ?       10           
  Lines                                           ?     1293           
  Branches                                        ?        0           
=======================================================================
  Hits                                            ?      855           
  Misses                                          ?      408           
  Partials                                        ?       30           
Flag Coverage Δ
unittests 66.12% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@maurafortino maurafortino merged commit 47fd0b6 into denopink/chore/restructure-code-base Nov 3, 2023
14 checks passed
@maurafortino maurafortino deleted the metrics-package branch November 3, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants