Fix bug with limit version of torchvision because of basicsr and gfpgan.archs #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix bug with version torchvision limit
fix bug with version torch limit
Chouia-Abderrahman
approved these changes
Nov 28, 2024
AbderrahmanCharik
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I encountered an issue with compatibility in issue #768 and wanted to share a solution that avoids limiting the torchvision version. Instead of enforcing a version constraint, we can make the code more flexible by dynamically adding any missing functions from torchvision.transforms.functional_tensor. This approach maintains compatibility across versions, allowing the code to benefit from performance and optimizations in newer versions of Torch and TorchVision as they become available.
Hope this helps streamline version handling in the project!