-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add password complexity #41
Open
6greenhand
wants to merge
11
commits into
ximatai:master
Choose a base branch
from
6greenhand:add_password_complexity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+197
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruis
reviewed
Dec 26, 2024
@@ -193,7 +193,7 @@ void test() { | |||
.when() | |||
.post("/api%s/userinfo/setPasswordSelf/%s".formatted(base, id)) | |||
.then() | |||
.statusCode(200) | |||
.statusCode(500) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该修改之前的密码,让它符合要求,验证码仍未200,才对。
同时,要补充新的单元测试,专门测试密码不符合要求的几种情况。
要用断言测试平台的报错信息跟预想的相同。
aruis
reviewed
Dec 26, 2024
@@ -216,6 +231,20 @@ public int setPasswordSelf(@PathParam("id") String id, Map<String, Object> param | |||
throw new MyException("两次输入的密码不一致"); | |||
} | |||
|
|||
List<Map> childTableList = dictCategoryController.getChildTableList("password_complexity", "app_dict", null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有重复代码,要考虑复用。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.