Merge pull request #159 from vivekkumac/logVersion

Added a few minor fixes, logger code improved, added unittests and removed obsolete code from utils.py and ssh.py

acktools/tests/acktools_tests.py

@@ -8,17 +8,13 @@
 
 class MockProcess:
 
-    returncode = 0
-    stderr = None
-
     def __init__(self, output, err=None):
         self.output = output
-        if err:
-            self.returncode = 1
-            self.stderr = err
+        self.returncode = 1 if err else 0
+        self.__stderr = err
 
     def stderr(self):
-        return self.stderr
+        return self.__stderr
 
     def stdout(self):
         return self.output

autocertkit/ack_cli.py

@@ -417,15 +417,10 @@ def main(config, test_run_file):
 
     session = get_xapi_session(config)
 
-    # Release current logger before running logrotate.
-    utils.release_logging()
-
-    # Run log rotate before ACK produces any log.
-    for host_ref in session.xenapi.host.get_all():
-        session.xenapi.host.call_plugin(host_ref, 'autocertkit',
-                                        'run_ack_logrotate', {})
-    utils.configure_logging('auto-cert-kit')
+    # Start Logger
+    utils.init_ack_logging(session)
 
+    # Pre checks before running tests
     pre_flight_checks(session, config)
 
     config['xs_version'] = utils.get_xenserver_version(session)
@@ -446,6 +441,7 @@ def main(config, test_run_file):
     test_file, output = test_runner.run_tests_from_file(test_run_file)
 
 if __name__ == "__main__":
+    # Parse Args
     config = parse_cmd_args()
 
     # Default config file

autocertkit/cpu_tests.py

@@ -33,8 +33,6 @@
 import testbase
 from utils import *
 
-log = get_logger('auto-cert-kit')
-
 
 class PerfTestClass(testbase.CPUTestClass):
     """A somewhat generic test class for CPU performance tests

autocertkit/network_tests.py

@@ -36,8 +36,6 @@
 import sys
 import math
 
-log = get_logger('auto-cert-kit')
-
 
 class FixedOffloadException(Exception):
     pass

autocertkit/operations_tests.py

@@ -32,8 +32,6 @@
 import time
 from utils import *
 
-log = get_logger('auto-cert-kit')
-
 
 class VMOpsTestClass(testbase.OperationsTestClass):
     """Test class to determine proper operation of the most