Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced instances of single quotes with double quotes across TS SDK Codebase #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

one2code
Copy link

Inconsistencies in formatting as noted in issue #33

There's inconsistent styling across the codebase, with mixed use of ' ' and " " in several of the files

Solution

Replace all instances of ' ' with " " using the Prettier formatter, to update older files with a style that is consistent with the newer files

Describe the modifications you've done.

Result

Replaced all instances of ' ' with " " where found in the codebase under the /src folder, and it's children directories

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@ojmarte ojmarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

Great work on this PR! The changes from single to double quotes are spot-on, ensuring our codebase remains consistent with our style guidelines. Additionally, the adjustments made to the code indentation are excellent. They not only improve the readability of our code but also demonstrate attention to detail in maintaining clean and well-structured code. These may seem like small tweaks, but they're important for maintaining the overall quality of our project. Nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants