Add basic WAMP client #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzzammilshahid
force-pushed
the
client
branch
2 times, most recently
from
9d08cae to
071fe81
Compare
om26er
requested changes
May 1, 2024
lib/src/session.dart
Outdated
| Future.microtask(() async { | ||
| while (true) { | ||
| await _baseSession.receive().then( | ||
| (value) => _processIncomingMessage(_wampSession.receive(Uint8List.fromList((value as String).codeUnits))), |
There was a problem hiding this comment.
might want to assign values first and use them instead of chaining them
lib/src/session.dart
Outdated
|
|
||
| final Map<int, Completer<Result>> _callRequests = {}; | ||
| final Map<int, RegisterRequest> _registerRequests = {}; | ||
| final Map<int, Yield Function(Invocation)> _registrations = {}; |
There was a problem hiding this comment.
As far as user api is concerned this should have a new class Result AND Invocation defined in types. So instead of Yield we will use Result. NOTE Result wont be a wamp message type but rather a normal class. See wamp.py
om26er
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.