Add tests for session #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzzammilshahid
force-pushed
the
session-tests
branch
from
43ef9fd to
f8c949c
Compare
om26er
reviewed
May 14, 2024
lib/src/types.dart
Outdated
| @@ -243,7 +243,7 @@ class ClientSideLocalBaseSession implements IBaseSession { | |||
|
|
|||
| @override | |||
| Future<Object> receive() async { | |||
| if (_incomingMessages.isEmpty) { | |||
| while (_incomingMessages.isEmpty) { | |||
There was a problem hiding this comment.
why do we need while statement here? Is this trying to workaround something?
muzzammilshahid
force-pushed
the
session-tests
branch
2 times, most recently
from
235dae0 to
06b051d
Compare
muzzammilshahid
force-pushed
the
session-tests
branch
from
06b051d to
3224884
Compare
om26er
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.