Merge pull request #60 from muzzammilshahid/fix-publish-request

Fix: Save publish request only if acknowledgment is true
xconnio · Oct 16, 2024 · 64ca6f4 · 64ca6f4
2 parents 9db87f9 + 261f86c
commit 64ca6f4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
@@ -17,7 +17,7 @@ jobs:
       - name: Set up Dart
         uses: dart-lang/setup-dart@v1
         with:
-          sdk: 3.3.0
+          sdk: 3.4.0
 
       - name: Install dependencies
         run: make install

diff --git a/lib/src/session.dart b/lib/src/session.dart
@@ -208,12 +208,13 @@ class Session {
   }) {
     var publish = msg.Publish(_nextID, topic, args: args, kwargs: kwargs, options: options);
 
-    var completer = Completer<void>();
-    _publishRequests[publish.requestID] = completer;
     _baseSession.send(_wampSession.sendMessage(publish));
 
     var ack = options?["acknowledge"] ?? false;
     if (ack) {
+      var completer = Completer<void>();
+      _publishRequests[publish.requestID] = completer;
+
       return completer.future;
     }