Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin.video.opentakserver] 1.0.0 #4606

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[plugin.video.opentakserver] 1.0.0 #4606

merged 1 commit into from
Dec 23, 2024
+820 −0

Conversation

brian7704
Copy link

Description

View video streams and recordings from OpenTAKServer

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.
  • If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

@basrieter
Copy link
Contributor

Please make the add-on checker happy.

@brian7704
Copy link
Author

I resized the logo and removed the transparency. Also renamed main.py to addon.py due to the 15 line warning for main.py

basrieter
basrieter requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@basrieter basrieter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at my comments.

Besides that: could you explain a bit what this plugin will do?

plugin.video.opentakserver/addon.py Outdated
def get(url):
auth_token = get_auth_token_from_file()

r = requests.get(url, params={'auth_token': auth_token}, verify=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think verify=False should be configurable: some might actually have certificates and then they don't want to just ignore invalid ones?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PR with this option

plugin.video.opentakserver/addon.py Outdated
return '{}?{}'.format(URL, urlencode(kwargs))


def list_videos():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will always return an empty listing?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been removed

plugin.video.opentakserver/addon.xml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide language for the add-on using the <language> tag and perhaps add a <website> or <source>?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tags have been added

@brian7704
Copy link
Author

I'll fix those issues and update the PR.

I'm the developer of OpenTAKServer which is a self hosted, open source backend for ATAK. One of OpenTAKServer's features is the ability to pull in video feeds from various sources such as IP cameras, online streams, drones, etc using MediaMTX. This plugin allows users to view those streams in Kodi.

@basrieter basrieter merged commit a1ce878 into xbmc:omega Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basrieter basrieter basrieter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brian7704 @basrieter