Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.orftvthek@matrix] 1.0.2 #4527

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

s0faking
Copy link

Add-on details:

ORF ON - This plugin provides access to the Austrian ORF ON streaming service

Description of changes:

v1.0.2
- new Livestream (timeshift)
- added setting to use old livestream format
- LF conversion
- list callback fix main menu
- add license
- forum fix addon.xml

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Copy link
Contributor

@basrieter basrieter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments.

Comment on lines +111 to +112
Player().play(streaming_url, play_item)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the setResolvedUrl method to start playback.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this call is used for playing the livestream from the start using the context menu. I couldn't find another way to do that since the context menu can't be playable (afaik). did this the same way in the previous versions as well (https://github.com/s0faking/plugin.video.orftvthek/blob/b76d8e2993a0d70a205b3073b14e3193d1e5ff8a/resources/lib/Addon.py#L233)

@basrieter basrieter merged commit 3467d09 into xbmc:matrix Jun 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants