Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.cc.com] 1.0.0 #3864

Open
wants to merge 1 commit into
base: matrix
Choose a base branch
from
Open

[plugin.video.cc.com] 1.0.0 #3864

wants to merge 1 commit into from

Conversation

nixxo
Copy link

@nixxo nixxo commented Jan 23, 2022

Description

An addon to browse and view content from Comedy Central's website (cc.com).

First public release for the Kody repo.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

@nixxo nixxo marked this pull request as draft January 23, 2022 22:23
@nixxo nixxo marked this pull request as ready for review January 23, 2022 22:48
@Lunatixz
Copy link

Lunatixz commented Feb 25, 2022

@nixxo pls drop the included yt_dl and use https://github.com/xbmc/repo-scripts/tree/matrix/script.module.youtube.dl
I'll continue code review after that, THX

@nixxo
Copy link
Author

nixxo commented Feb 26, 2022

@Lunatixz the youtube.dl module is outdated and useless for my addon.

That's why I created my own version of yt-dlp https://github.com/yt-dlp/yt-dlp (a youtube-dl fork I'm a contributor) that only works with comedycentral content.

See here: https://github.com/nixxo/yt-dlp/tree/cc-only

Since I would like to provide an addon that stays up to date if the website changes, I'd prefer not to rely on external modules that are not updated for almost a year.

@Lunatixz
Copy link

Lunatixz commented Feb 26, 2022

@nixxo

I understand, the youtube.dl module can become outdated. I believe I saw a pending PR a few days ago. xbmc/repo-scripts#2190 maybe that will help?

If you would like to add custom manipulation of a module for a special use case please use the "monkey patch" method.
Duplicated modules packed individually into a plugin are against repository guidelines... at least when the module is on the scale of youtube_dl...

I attached a helpful link if you are not familiar with "monkey patching":
https://medium.com/@chipiga86/python-monkey-patching-like-a-boss-87d7ddb8098e

@Lunatixz Lunatixz added the WIP label Feb 26, 2022
@nixxo
Copy link
Author

nixxo commented Feb 26, 2022

to me both solutions are fine.

I'll give a look at monkey patching to learn something new, but I suggest to approve the new version of youtube-dl addon. It's almost 1 year old and many websites likely don't work.

As I said my version is based on the youtube-dl addon version that you linked (I'm a contributor to that fork)
About the 'scale' at the module, my version is <300kb from the +3Mb, as I mentioned I removed everything except comedycentral.com related stuff and almost everything that is related to console usage, it's almost a 'lib only' version at this point.

@Lunatixz
Copy link

Yes, what I mean by scale is let's say the module is a few lines of code and you are refactoring 85% of it for an individual plugin.. In that case, I can understand and approve it packed as "original" code... Any changes greater than that and I would recommend packing your own custom module and submitting it for approval along with your plugin.

Neither case applies to your project...

I'll look into what is holding up the youtube_dl PR.

@enen92
Copy link
Member

enen92 commented May 20, 2022

@nixxo any news on this one?

@nixxo
Copy link
Author

nixxo commented May 20, 2022

I was waiting for the yt-dlp addon to be approved...

I think I have to create my own class to handle media extraction from the website (similar to the southpark addon) and avoid depending on external addons not getting updated.

I'll look into it this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants