Feature: Enable search in grid/wall view #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be merged after #521. |
|
Please fix conflicts |
wutschel
force-pushed
the
grid_search
branch
from
8002d18 to
1e217c2
Compare
|
Rebased to master. |
wutschel
force-pushed
the
grid_search
branch
from
1e217c2 to
ab2ab7a
Compare
kambala-decapitator
requested changes
Jan 7, 2022
kambala-decapitator
requested changes
Jan 7, 2022
kambala-decapitator
approved these changes
Jan 7, 2022
Disconnect searchController from dataList.tableHeaderView when entering grid view mode. Connect it back again when re-entering list view. This resolves an issue where the search bar was not properly shown in grid view after first being initialized in list view.
The delegates were implemented to implement a workaround for UISearchDisplayController under iOS7. This is not effective anymore and can be removed.
Use the same icon as iOS's index (magnifying glass with transparent circle, handle bar to lower right side).
- Call init during first time setup of grid/wall view - Set visibility when initializing and when changing the view - Set invisible during search and restore after search ended - Use the magnifying lens directly, avoiding the UTF code fixup: magnifier lens
The index is only shown when there are valid index titles which are derived from the sections. But for fullscreen the sections are removed. As the check for visibility is called from configureLibraryView, we just need to move the call of configureLibraryView before the sections are emptied out.
This is a workaround. If not deactivating the search the ShowViewController cannot be presented.
Before this change the fullscreen's searchbar first appearance was too small when entering this from a list view.
|
Squashed fixups and rebased to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #467.
This PR enables the search in grid/wall view (tested with albums, artists and movies):
Screenshots:
https://abload.de/img/simulatorscreenshot-iqrkga.png
https://abload.de/img/simulatorscreenshot-iajj2g.png
https://abload.de/img/simulatorscreenshot-i9tk5e.png
Summary for release notes
Feature: Enable search in grid/wall view