CP-52881: add mechanism to filter out event fields #6184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should also add a similar mechanism to get_all_records. A better fix might be to change the type of the field to a ref and move it out to a class of its own and do a DB upgrade. Signed-off-by: Edwin Török <[email protected]>
lindig
approved these changes
Dec 16, 2024
| let apply_event_filter = function | ||
| | Rpc.Dict lst as orig -> | ||
| let lst' = maybe_map_fields lst in | ||
| if lst' == lst then |
There was a problem hiding this comment.
Should add a comment that == is indeed what we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should also add a similar mechanism to get_all_records.
A better fix might be to change the type of the field to a ref and move it out to a class of its own and do a DB upgrade.
It might be better to do this at the DB action level when generating
get_record, although we need to ensure we don't lose these values completely: we do need to retain them when saving the XAPI DB.We should really have an Event.from_filtered API too that allows the client to define a field filter.