Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay: wait a bit more testing the module #6162

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

freddy77
Copy link
Collaborator

@freddy77 freddy77 commented Dec 6, 2024

In some environments the time ranges checked are too strict causing test to fail.
Previously the maximum error accepted was 10 ms, increase to 50 ms.
Also increase timeouts to reduce error/value ratio.

In some environments the time ranges checked are too strict causing test to
fail.
Previously the maximum error accepted was 10 ms, increase to 50 ms.
Also increase timeouts to reduce error/value ratio.

Signed-off-by: Frediano Ziglio <[email protected]>
Copy link
Member

@psafont psafont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous timing were too tight for the github's CI. It failed last on on the xs-opam's nightly run, for example.

@robhoes robhoes added this pull request to the merge queue Dec 6, 2024
Merged via the queue into xapi-project:master with commit f14fcdf Dec 6, 2024
15 checks passed
@freddy77 freddy77 deleted the not_so_fast branch December 6, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants