Add constructor from TS to TS. Add Base.copy and Base.similar with the DataFrame semantics. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiraganand
requested changes
May 18, 2022
src/TS.jl
Outdated
| @@ -201,10 +201,10 @@ julia> ts = TS([random(10) random(10)], dates) # matrix object | |||
| """ | |||
| struct TS | |||
|
|
|||
| coredata :: DataFrame | |||
| coredata::DataFrame | |||
There was a problem hiding this comment.
Please commit formatting changes such as space removals in a separate PR. It gets difficult to review the diffs.
src/utils.jl
Outdated
|
|
||
| ``` | ||
| """ | ||
| Base.similar(ts::TS, rows::Integer=nrow(ts)) = TS(similar(ts.coredata, rows)) |
There was a problem hiding this comment.
Can you change similar(ts.coredata, ...) to use DataFrames.similar()? This is to avoid conflicts if both packages are loaded into REPL.
Emmanuel-R8
commented
May 19, 2022
|
@chiraganand @codetalker7 are Base.copy and Base.similar required? Either close PR or review and suggest changes to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.