Handle client exception when API is disabled #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
ShanChathusanda93
approved these changes
Sep 27, 2023
|
PR builder completed |
jenkins-is-staging
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6324433884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Due to the encountered issues with the current V1 API, a new V2 API is provided. Hence, current recovery service will be disabled. There will be a config to enable/disable the service. This PR handles the client exception when the recovery service is disabled.
Related issue: wso2/product-is#16536
When should this PR be merged
This should be merged after wso2-extensions/identity-governance#766
Governance version: v1.8.73