Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the default authenticationUrl value which added in the Implicit Grant type #12310

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

piyumaldk
Copy link
Contributor

@piyumaldk piyumaldk requested a review from tharikaGitHub March 6, 2024 11:54
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 44.66%. Comparing base (df47529) to head (2915589).
Report is 21 commits behind head on master.

Files Patch % Lines
...so2/carbon/apimgt/impl/definitions/OAS2Parser.java 50.00% 0 Missing and 2 partials ⚠️
...so2/carbon/apimgt/impl/definitions/OAS3Parser.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12310      +/-   ##
============================================
+ Coverage     42.22%   44.66%   +2.44%     
- Complexity        0     3655    +3655     
============================================
  Files          1840     1840              
  Lines        136407   136414       +7     
  Branches      19734    19738       +4     
============================================
+ Hits          57598    60933    +3335     
+ Misses        71882    68185    -3697     
- Partials       6927     7296     +369     
Flag Coverage Δ
integration_tests 39.11% <40.00%> (+3.48%) ⬆️
unit_tests 20.45% <70.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piyumaldk
Copy link
Contributor Author

Carbon APIMGT tests are passing locally

@piyumaldk
Copy link
Contributor Author

Product APIM build (tests are skipped) is successful with the changes. Fix is working fine in the pack.

@piyumaldk piyumaldk merged commit fe165e7 into wso2:master Mar 20, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override the default authenticationUrl value which added in the Implicit Grant type
2 participants