Add multiOptionURI parsing for additional query parameters #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12365565084
...java/org/wso2/carbon/identity/application/authenticator/oidc/OpenIDConnectAuthenticator.java
Show resolved
Hide resolved
DilshanSenarath
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
When configuring the authentication steps for a service provider, if the first step has multiple authentication choices between with an OIDC federated IdP as one of them, when the user picks the federated IdP, they are redirected to the federated IdP's login page to proceed.
When this redirection happens, the URL query parameters originally included in the request are encoded and included in the request as a parameter called multiOptionURI.
When parsing the request's query parameters to interpret the additional query parameters, the encoded value of multiOptionURI is not considered.
With this PR, if the additional query parameter isn't present in the request parameters, it will check if the multiOptionURI parameter is available and check if the additional query parameter is present here instead.
Related Issues